Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] stock_move_location: Move Line destination would stay the default #1964

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

dreispt
Copy link
Member

@dreispt dreispt commented Mar 18, 2024

Closes #1963

@dreispt dreispt force-pushed the 16-dr-stock_move_location-fix branch from 87d2c7d to 14059e8 Compare March 18, 2024 14:50
@dreispt dreispt changed the title [FIX] stock_move_location: Move Line destination would stay the default [16.0][FIX] stock_move_location: Move Line destination would stay the default Mar 18, 2024
<field name="destination_location_id" />
<field
name="origin_location_id"
force_save="1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreispt Are you sure this is necessary as force_save should be used if field is readonly

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sure: these values are changed though a form onchange, but the changes are not saved because it is read only.
The force_save is already there for the list view, but I found it is also needed for the kanban view.

Copy link

github-actions bot commented Aug 4, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 4, 2024
@dreispt dreispt removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[16.0] stock_move_location: wrong destination location
2 participants