Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to libbase58/libblkmaker #4

Open
luke-jr opened this issue Oct 18, 2024 · 2 comments
Open

Port to libbase58/libblkmaker #4

luke-jr opened this issue Oct 18, 2024 · 2 comments

Comments

@luke-jr
Copy link
Contributor

luke-jr commented Oct 18, 2024

Better to use the dependencies directly rather than bundle a copy of them

@jesterhodl
Copy link
Contributor

You mean add a submodule of https://github.com/luke-jr/libbase58 and use that instead of thirdparty_base58* ?

I could do that if there are no differences, or any potential differences from datum_gateway would need to go upstream to your fork of libbase58

@luke-jr
Copy link
Contributor Author

luke-jr commented Oct 21, 2024

No need for it to be a submodule, these libraries can be installed and used via pkg-config the same as the rest. See #14

The bigger project is rewriting the code to use libblkmaker to create the blocks and parse the GBT results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants