Resolver.workspace_from_url: usage of clobber_mets not consistent with the docstring

[hnesk]

clobber_mets = False does not raise an exception for existing mets.xml ('raise'), but fails silently ('skip')

core/ocrd/ocrd/resolver.py

Line 114 in 4e11b8e

clobber_mets (boolean, False): Whether to overwrite existing mets.xml. By default existing mets.xml will raise an exception.

see:

core/ocrd/ocrd/resolver.py

Line 154 in 4e11b8e

self.download_to_directory(dst_dir, mets_url, basename=mets_basename, if_exists='overwrite' if clobber_mets else 'skip')

I don't know what would be the right thing to do: Fix the docstring or fix the implementation?

[bertsky]

I don't know what would be the right thing to do: Fix the docstring or fix the implementation?

I'd prefer the latter option.

[hnesk]

Oh, I just found this PR #425 (review)

[bertsky]

@kba this needs to be revisited – including the discussion after #425.

We still have:

core/src/ocrd/resolver.py

Line 221 in 987da9b

self.download_to_directory(dst_dir, mets_url, basename=mets_basename, if_exists='overwrite' if clobber_mets else 'skip')

At the very least, the docstring needs to be fixed.