Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align pypi and anaconda channel packaging and setup efforts #49

Closed
emiliom opened this issue Apr 8, 2016 · 7 comments
Closed

Align pypi and anaconda channel packaging and setup efforts #49

emiliom opened this issue Apr 8, 2016 · 7 comments

Comments

@emiliom
Copy link
Member

emiliom commented Apr 8, 2016

@ocefpaf and I are working on a new ODM2 anaconda channel for easy, multi-OS distribution of ODM2 packages (odm2api initially, others later on). We have the ODM2 channel already created with odm2api and its dependencies, already installable on Linux and OSX (some Windows glitches are being worked on).

@valentinedwv is working on PyPI packaging, and already has this on the test pypi environment. He also has overhauled requirements.txt and setup.py in the setup_clean branch and has a PR (#46) waiting in the wings with these changes (I asked to delay merging it for now).

@valentinedwv also has refactored the code to make individual RDBMS packages (eg, psycopg2, pyodbc) optional user-driven installs, so a MSSQL user never has to care about or install PostgreSQL requirements. See issue #44.

In addition, there's a raft of great new odm2api overhauls that @sreeder has done and I just reviewed, also waiting in the wings. And we're now using tagged (pre) releases (thanks, @sreeder!).

These are all fantastic developments!! But it's time to coordinate so we don't trip over each other, we leverage each other's efforts and expertise, and we make the best joint decisions.

I'll stop here and add a follow-up, next-step comment in a few minutes. I'll ping @aufdenkampe and @horsburgh directly, b/c I think this is important enough that they should be directly aware or involved at least initially.

@emiliom
Copy link
Member Author

emiliom commented Apr 8, 2016

The packaging and setup experts here are probably @ocefpaf and @valentinedwv (definitely not me!). So I think the first step is probably to have @ocefpaf review the setup changes from @valentinedwv in his PR; see my brief comment on it. If we can get agreement between the two of you on requirements.txt, requirements_tests.txt and setup.py to meet the needs of pypi, conda, and github/git-driven development, that'll be fantastic!

@ocefpaf
Copy link
Member

ocefpaf commented Apr 8, 2016

Sure. I will get to it later today early tomorrow.

Edit: xref https://github.com/ocefpaf/conda-recipes-ODM2/pull/11

@emiliom
Copy link
Member Author

emiliom commented Apr 8, 2016

Great!

@valentinedwv
Copy link
Member

For YodaTools, can you add this package to conda:
valideer

@emiliom
Copy link
Member Author

emiliom commented Apr 15, 2016

@ocefpaf and @valentinedwv, you've put a lot of effort into stuff related to this. Would you say that we're in good shape now with respect to setup, requirements, packaging and pypi vs conda? If so, we can close this issue.

@ocefpaf
Copy link
Member

ocefpaf commented Apr 20, 2016

@ocefpaf and @valentinedwv, you've put a lot of effort into stuff related to this. Would you say that we're in good shape now with respect to setup, requirements, packaging and pypi vs conda? If so, we can close this issue.

👍

There is always room for improvement, but it is much better now! Thanks @valentinedwv!!

@emiliom
Copy link
Member Author

emiliom commented Apr 20, 2016

Great, thanks. Closing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants