Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation standard? #97

Open
lsetiawan opened this issue Sep 27, 2017 · 2 comments
Open

Documentation standard? #97

lsetiawan opened this issue Sep 27, 2017 · 2 comments

Comments

@lsetiawan
Copy link
Member

I notice that docstrings of functions and classes are a bit confusing. And issue #94 points out that there isn't really a built in documentation for the objects returned by the api calls.

After looking at various popular python libraries out there, it seems like a lot of them follows the Numpy/Scipy docstring documentation style.

@ocefpaf will set up ODM2PythonAPI documentation to follow a similar approach to Folium. Looking at the code it seems like this library also follows the numpy/scipy documentation style (@ocefpaf, please correct me if I'm wrong).

Given those circumstances, I propose that we use the numpy/scipy standard when documenting the code. What do you all think? @emiliom @ocefpaf @aufdenkampe @horsburgh @sreeder ?

@emiliom
Copy link
Member

emiliom commented Sep 27, 2017

👍 thanks @lsetiawan and @ocefpaf.

FYI (to others), Filipe, Don and I discussed this yesterday. The system we'll implement will be tied into Travis CI so that docs are autoupdated, and will also be versioned with each tagged release. Don is taking the first steps to set up this system. Stay tuned!

@ocefpaf
Copy link
Member

ocefpaf commented Sep 27, 2017

Looking at the code it seems like this library also follows the numpy/scipy documentation style (@ocefpaf, please correct me if I'm wrong).

I try to but I may not be consistent there. Lately I'm using a more terse and simple style, see https://github.com/ocefpaf/erddapy/blob/master/erddapy/erddapy.py

However, both are fine, I don't really have a preference here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants