Fixes #1301: Enable read the property without value #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhg
requested review from
KenitoInc,
habbes,
mikepizzo,
ElizabethOkerio and
gathogojr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1301 Enable read property without value
ODL supports to read the property without value. Here's an example:
{ "@odata.context":"http://localhost/$metadata#Customers/$entity", "CustomerID": 17, "Name@Custom.PrimitiveAnnotation":123, "Name@Custom.BooleanAnnotation":true, "Location": { "Street":"154TH AVE"} }where, the property 'Name' only contains the instance annotations.
ODL can read the above properties and output the 'ODataReaderState.NestedPropertyInfo' in the reading pipeline.
This PR is to handle ''ODataReaderState.NestedPropertyInfo' and hold the 'ODataPropertyInfo' instances into a container, and provides an solution for end users to access such properties by customizing the deserializer.
It's a PR to retrieve the reading process out of the whole instance annotation features and try to make it small enough but a complete feature.
Make the PR as small as possible to help the code reviewing.