How to redirect route to action or function from custom routing convention

[komdil]

My controller and configuration:

    [EnableQuery]
    public class StudentController : ODataController
    {
        IStudentRepository _studentRepository;

        public StudentController(IStudentRepository studentRepository)
        {
            _studentRepository = studentRepository;
        }

        [HttpPost]
        public IActionResult Run([FromRoute] Guid key)
        {
            var student = _studentRepository.GetStudents().Include(s => s.Address).FirstOrDefault(a => a.Address != null);
            return Ok(student);
        }
    }

    public class Student
    {
        public Guid Id { get; set; }

        public string Name { get; set; }

        public virtual Address Address { get; set; }
    }

    public class Address
    {
        public Guid Id { get; set; }

        public string Street { get; set; }
    }
    static IEdmModel GetEdmModel(ODataConventionModelBuilder odataBuilder)
    {
            var student = odataBuilder.EntityType<Student>();
            student.HasKey(s => s.Id);
            var action = student.Action("Run").ReturnsFromEntitySet<Student>("Student");
            odataBuilder.EntitySet<Student>("Student");
            return odataBuilder.GetEdmModel();
     }

My action is working good, I am sending request with queries ($select and $expand), like: https://localhost:44383/odata/Student/aefea1de-9043-4c0b-88a2-04f77918ffef/Run?$expand=Address&$select=Id

It is returning me response like:

{
    "@odata.context": "https://localhost:44383/odata/$metadata#Student(Id,Address())/$entity",
    "Id": "1e44bfb1-f0f7-4568-9e1a-0000b86e150c",
    "Address": {
        "Id": "deb7eee0-03f7-4668-a213-52cb5fc176a6",
        "Street": "Street #49174"
    }
}

It is expected.

Now, I want when client sends request with some prefix, for example: abcRun, commandRun, .... it should use that route. To do that I created custom routing convention:

public class MyRoutingConvention : EntitySetRoutingConvention
    {
        public const string EntityKeyUnResolvedPath = "~/entityset/key/unresolved";
        public override string SelectAction(RouteContext routeContext, SelectControllerResult controllerResult, IEnumerable<ControllerActionDescriptor> actionDescriptors)
        {
            var context = routeContext.HttpContext;
            var odataPath = context.ODataFeature().Path;
            if (odataPath.PathTemplate == EntityKeyUnResolvedPath)
            {
                return nameof(StudentController.RunWithPrefix);
            }
            return base.SelectAction(routeContext, controllerResult, actionDescriptors); ;
        }
    }

Now, I added this method on my controller:

        [HttpPost]
        public IActionResult RunWithPrefix([FromRoute] Guid key)
        {
            return Run(key);
        }

Now, When I send request like: https://localhost:44383/odata/Student/aefea1de-9043-4c0b-88a2-04f77918ffef/abcRun?$expand=Address&$select=Id

It is returning this response:

{
    "@odata.context": "https://localhost:44383/odata/$metadata#Student(Id,Address())/$entity",
    "@odata.type": "#Model.Entities.Student",
    "Id": "1e44bfb1-f0f7-4568-9e1a-0000b86e150c"
}

I was expecting that both should return the same response, but it didn't. It seems expand is not working. Does someone know how to make it work?

[xuzhg]

@komdil Would you please share a repro for me to dig more?

[komdil]

https://github.com/komdil/ODataCoreTest/tree/actionRC

You can run these requests and see the difference:
https://localhost:44383/odata/Student/f3542e7d-c24c-4288-8d55-00001752f4bb/Run
https://localhost:44383/odata/Student/f3542e7d-c24c-4288-8d55-00001752f4bb/commandRun