-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-Code The CSS for The Banner and Cookie Manager #26
Comments
Might also be a good idea tot look at general styling of the elements. There's a min-height on the cookiesmanager for example that's not really necessary I think. |
CSS on Banner won't pass basic Web Accessibility standards! Gonna have to throw it in the bin and re-code it properly! |
@CptMeatball I will check that as well. Probably lots of issues there as well. |
@tobias-kuendig Hi, sorry for my words and yes I did use the viewport tag. But the current CSS will completely fail if you throw it into Lighthouse for example, I strongly do not recommend anyone use the current css and I will do a major update to it today and correct all the errors! That is why I say throw it in bin, as I recommend users to not use the current version! ~Anyway leave it with me I will work on this today. |
I actually prefer the left one. Also, design is something that probably is different across websites. The gradient buttons on the new design are not really in sync with the current design trends and I'm also not that fond of the yellow. The old design seems a bit a cleaner. |
Thank you @ayumihamsaki for updating the CSS. I will remove the gradients and clean up the design a bit. I tried to keep the design as simple as possible and make it easy for the enduser to adjust it to the site's design. Using solid background colors removes the need for vendor prefixes. I don't know what versions of browsers you were targeting but I may also remove some other vendor prefixes like box-shadow and transition since theses properties had good browser support for many month now. |
Gonna do a Pull Request to update the CSS to work on all Browsers with the added prefix and also create min files to add to the updated doc's at a later date.
The text was updated successfully, but these errors were encountered: