-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'warning off' #15
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In general, the pattern
this can lead to unpredictable behaviour (specifically, other unrelated warnings unexpectedly not being raised) if an error occurs while running
stuff()
. It would be better to check explicitly for the warning conditions. For example, instead ofit should read
This needs to be replaced in a number of places. As a somewhat weaker alternative, in some places specific warnings could be disabled instead of all warnings e.g. suppressing divide by zero warnings
The text was updated successfully, but these errors were encountered: