-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for DQD v2.0 #199
Comments
Sample DQD V2 file |
I haven't found any breaking changes in the DQD v2 generated file. There are 1-2 properties missing, a few additional ones, but the ones missing do not seem to be used by Ares. Haven't seen any issues on my side using the v2 file. Could you please describe the issues you encountered? |
One issue I've seen is in the execution of AresIndexer::buildDataQualityIndex Error in I think this is associated with the change of the types of status that can exist in DQD v2. Also going forward with DQD v2 results we'll want to add summaries for failes, passed, is_error, and not_applicable to AresIndexer as well as the reports in Ares. |
Related to this potential fix: |
Describe the solution you'd like
I would like to ensure that the JSON file produced by DQD v2.0 is supported by ARES
We made some changes to the DQD in v2.0 and I am not sure if those changes will break anything when ARES tries to render the JSON. We have already seen some issues at Janssen with this but we are not entirely sure of the problem.
The text was updated successfully, but these errors were encountered: