Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report stored MDRR in power tab, not re-computed one #348

Open
schuemie opened this issue Sep 26, 2024 · 1 comment
Open

Report stored MDRR in power tab, not re-computed one #348

schuemie opened this issue Sep 26, 2024 · 1 comment
Labels
bug Something isn't working Estimation

Comments

@schuemie
Copy link
Member

In the CohortMethod power tab, the MDRR is shown. This is computed on the fly based on the counts. However, the problem with this is that the counts might be masked because they were below the minCellCount. The current code simply takes the absolute value of the count, meaning in the case of masking it assumes the value of minCellCount: https://github.com/OHDSI/OhdsiShinyModules/blob/main/R/estimation-cohort-method-power.R#L354

This can lead to different MDRR numbers between the Diagnostics tab and the power tab.

Could we just pull the pre-computed MDRR from the cm_diagnostics_summary table instead?

@schuemie
Copy link
Member Author

Note that the current calculations in OhdsiShinyModels always assumes we are using a Cox model, which isn't necessarily true

@nhall6 nhall6 added bug Something isn't working Estimation labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Estimation
Projects
None yet
Development

No branches or pull requests

2 participants