fix: 🐛 SVG orientation fix #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JamesAPetts
commented
Oct 12, 2020
JamesAPetts
commented
- The reference lines where inverted with respect to the canvas, due to not accounting for a switch from displayCoordinates to SVG, causing a clockwise rotation to map to an anti-clockwise rotation.
- Fixed this issue.
- Changed the rotatable crosshairs example to use a head scan, which makes it much easier to identify such issues.
|
🎉 This PR is included in version 0.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
radiologics-kate
pushed a commit
to radiologics/react-vtkjs-viewport
that referenced
this pull request
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.