Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ola - Gift Cards (BA) - compliance check #1859

Open
Rishabh-ondc opened this issue Dec 23, 2024 · 0 comments
Open

Ola - Gift Cards (BA) - compliance check #1859

Rishabh-ondc opened this issue Dec 23, 2024 · 0 comments

Comments

@Rishabh-ondc
Copy link

on_search

  • ⁠missing ITEM_DETAILS at items[1]

select

  • ⁠fulfillments can't be empty
  • ⁠if offers are not selected, then don't send offers array at all

confirm

  • ⁠missing SETTLEMENT_DETAILS tag-group
  • status should be in an enum format i.e. CREATED

on_confirm

  • How can fulfillments.state & order.status be CANCELLED upon order creation
  • missing id & params in payments
  • ⁠missing SETTLEMENT_DETAILS tag-group

on_cancel, on_update, on_status

  • ⁠missing id & params in payments
  • ⁠missing SETTLEMENT_DETAILS tag-group

status

  • order.id mismatch with id created on /on_confirm
  • status should be called post order creation & timestamp should be greater than that of /on_confirm

General issues

  • Log review PR is to be raised on ONDC-official.verification-logs repo, comments going forward shall be provided on the PR on the same
  • ⁠Please segregate action/ on_action calls in separate files & also provide brief description for all flows
  • Signature from action/on_action payload is not required in log submissions
  • ⁠invalid billing.address

@deepesh2008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant