fix: preview config variable naming #3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,7 +51,7 @@ jobs: | |||
| name: community-platform-pr-${{ github.event.number }} | |||
| secrets: > | |||
| VITE_SITE_VARIANT=preview | |||
| VITE_PROJECT_VERSION=${GITHUB_SHA} | |||
| VITE_PROJECT_VERSION=$${ github.sha }} | |||
There was a problem hiding this comment.
Looks like a mistake here, should be ${{ instead of $${
There was a problem hiding this comment.
Yep, fat fingers 🥲
I wish there was a test suite for GitHub actions to save me merging into master every time to test.
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fails due to incorrect variable parsing
What is the new behavior?
Should parse
Does this PR introduce a breaking change?
Git Issues
Closes #
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform
developmentchannel.