[bug] flag rendering doesn't update upon location change

[L4ZZA]

Describe the bug
Not all the flags are updated according to the location settings. It seems like the first one you choose upon account creation is left cached on the user object on the comments and on the profile details page.

To Reproduce

1. Create an account with any country selected as a Location (i.e. UK)
2. Upon creation completed, go to your profile and change the location to any other country.
3. In the preview it will show the correct one.
4. Click on the preview button
5. see that the flag on your profile page hasn't changed.
6. go to any of your previous comments
7. see that the flag hasn't changed there either

Expected behaviour
all the rendered flags should match the current/latest "Location" setting

Screenshots

Additional context
Could it be related to this? #3131

[davehakkens]

thanks for posting!

[ebradbury]

Hi @L4ZZA, I took a look at this bug and I think it's at least partially a UX issue. The preview is being displayed in real time when you select a location. You don't have to click the link to see the preview, the link is the preview. It's confusing because the app uses a Username component to show the preview and that component always renders as a link to your profile. So when you click you are taken to your profile which has your old location (since you haven't saved the form yet). I hope that makes sense.

I wasn't able to test whether your flag/location on comments gets updated but I did see that research modules were. I'm not exactly sure what the right behavior is here... keep the location what it was when you commented or update it to your current location.

Anyone have input?

[mariojsnunes]

Any UI issue could be fixed now.
But there probably is a data sync issue (too), which is gonna get fixed eventually by #4064

[ebradbury]

@mariojsnunes I think the issue is that the Username component always renders as a link to the profile. Should we make a new component that doesn't link for the sake of this preview feature?

[L4ZZA]

Anyone have input?

hey @ebradbury I have not looked at the code, but to me it feels like the location at which you register the account the first time is a different property/variable than the one use in the preview UI in the settings page. It seems to me like the two things are not connected at all

[L4ZZA]

@mariojsnunes cool! keep me posted on when that one is complete then and I'll check again :) thanks guys!