Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: discussion duplication #3993

Merged
merged 2 commits into from
Nov 7, 2024
Merged

fix: discussion duplication #3993

merged 2 commits into from
Nov 7, 2024

Conversation

mariojsnunes
Copy link
Contributor

@mariojsnunes mariojsnunes commented Nov 7, 2024

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix (fixes an issue)

What is the current behavior?

Discussions are being duplicated which causes comments to not show. There should only be 1 discussion per sourceId.

What is the new behavior?

Ensure that even with duplicated discussions, it shows the correct one.
Change that might prevent this duplication in the first place.

Does this PR introduce a breaking change?

  • Yes
  • No

Git Issues

Closes #

@mariojsnunes mariojsnunes requested a review from a team as a code owner November 7, 2024 18:32
@mariojsnunes mariojsnunes force-pushed the fix/duplicate-discussions branch from 2c00d2d to 953c78a Compare November 7, 2024 19:07
Copy link

cypress bot commented Nov 7, 2024

onearmy-community-platform    Run #6534

Run Properties:  status check passed Passed #6534  •  git commit bc10ec3f60: fix
Project onearmy-community-platform
Branch Review fix/duplicate-discussions
Run status status check passed Passed #6534
Run duration 05m 19s
Commit git commit bc10ec3f60: fix
Committer Mário Nunes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 74
View all changes introduced in this branch ↗︎

@mariojsnunes mariojsnunes merged commit 6bfb035 into master Nov 7, 2024
18 of 19 checks passed
@mariojsnunes mariojsnunes deleted the fix/duplicate-discussions branch November 7, 2024 21:18
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 2.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants