-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create API for questions search #3996
Conversation
030f316
to
1a01427
Compare
1a01427
to
10f4d08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is under a test folder because otherwise it would raise the following error:
Error: Vitest failed to access its internal state.
One of the following is possible:
- "vitest" is imported directly without running "vitest" command
- "vitest" is imported inside "globalSetup" (to fix this, use "setupFiles" instead, because "globalSetup" runs in a different context)
- Otherwise, it might be a Vitest bug. Please report it to https://github.com/vitest-dev/vitest/issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as for research, here:
#3987 (comment)
these tests are no longer useful. can remove the file, but add some cypress tests.
10f4d08
to
c1f0579
Compare
onearmy-community-platform Run #6671
Run Properties:
|
Project |
onearmy-community-platform
|
Branch Review |
pull/3996
|
Run status |
Passed #6671
|
Run duration | 05m 04s |
Commit |
2b7b2aa149: Merge branch 'master' into 3917-question-search-remix
|
Committer | benfurber |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
74
|
View all changes introduced in this branch ↗︎ |
Thanks for doing this @onim-at and especially for the cypress tests! I'll comment on them seperately, first the QA-ing though. I'm getting weird behaviour.
I'll add some categories to the preview DB too so I can check the categories. |
Added a category. Clicking on one doesn't seem to do anything. i.e. it doesn't select the option, add to the path or filter the list. |
85ec50e
to
ca4d8c9
Compare
Hello @benfurber! Thanks for the review and QA, I tried to reproduce the issues locally
That was a tricky bug! The
I fixed it by extracting first the URL, then the search params
I couldn't reproduce it locally, it looks ok to me😞
Same thing for the categories, it is working properly on my local |
Nice investigation on the search bug! I had a play with this locally using PP prod data (minus the new commenting stuff as I don't have all the prod creds I'd need for the env easily to hand). We've removed the comment ordering anyway for the moment so I think this can go through. Thanks @onim-at! |
🎉 This PR is included in version 2.17.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fetch questions via firestore
What is the new behavior?
Fetch questions via remix backend API
Does this PR introduce a breaking change?
Git Issues
Closes #3917
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform
development
channel.