Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Fixing behaviour of icons of 'Follow' and 'Mark as useful' buttons #4014

Open
dalibormrska opened this issue Nov 22, 2024 · 7 comments
Assignees
Labels

Comments

@dalibormrska
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently buttons unclicked:
image

Currently buttons clicked:
image

The issue is with these 2 buttons. They are colored from the beginning, when they are not clicked, and after click they Useful button turns black, while the Follow button icon stays the same.

From a design point of view, it makes sense to have them grey and make them colored when clicked. It is a standard in other platforms.
image

Describe the solution you'd like
image

Additional context
The upcoming feature of 'useful buttons for comments' will be having this behaviour, so it would be really good to have that behaviour consistent also with already existing buttons.

@arashveysi3
Copy link

leave it to me plzzzzz

@arashveysi3
Copy link

thanks @mariojsnunes
working on it

@arashveysi3
Copy link

arashveysi3 commented Nov 23, 2024

it runs on my local machine, questions and researches are creatable but when I try to open them I get a 404

the Error I get in backend when I try to view a question is:

Firestore (10.6.0): GrpcConnection RPC 'Listen' stream 0x54a5c2ab error. Code: 13 Message: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)

@mariojsnunes
Copy link
Contributor

I can see and open the questions you created. For research, I just added a role to your user that should fix it.

@arashveysi3
Copy link

same as before...

Screenshot (12)

@mariojsnunes
Copy link
Contributor

how about for questions/howtos?

@arashveysi3
Copy link

same for questions
but how-tos works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants