Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

academy routing #706

Closed
BenGamma opened this issue Oct 18, 2019 · 1 comment · Fixed by #808
Closed

academy routing #706

BenGamma opened this issue Oct 18, 2019 · 1 comment · Fixed by #808

Comments

@BenGamma
Copy link
Contributor

As it is an iframe now, you can only see the /academy.

Allow user to navigate with URLs. Update the routing depending on the iframe using postMessage

@chrismclarke
Copy link
Member

Just to elaborate a bit more, the academy uses an iframe to show content from a static site generated at: https://onearmy.github.io/academy

We want to be able to directly link to sections in the academy from the main site, i.e.,

https://onearmy.github.io/academy/plastic/basics
should be viewable at
https://dev.onearmy.world/academy/plastic/basics

This can probably be done simply by binding the iframe src url to a variable that also track the current site url. Alternatively (/possibly one for the future), we might want to look at better ways to communicate between both sites using postmessages.

Open for anyone interested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants