Please consider the minor fixes #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Nodes.jl
|
Thanks @tkrisnguyen. @mvanzulli or @mforets . do you have any comments on this pr? |
mvanzulli
reviewed
Oct 10, 2024
|
Also, can we create an issue for this PR https://github.com/ONSAS/ONSAS.jl/issues/new/choose ? |
mvanzulli
reviewed
Oct 11, 2024
|
The current status of CI must succeed to be merged, I would apply the suggestions above. I'm happy to have meeting if u need help. |
Co-authored-by: Mauricio Vanzulli <50339940+mvanzulli@users.noreply.github.com>
Co-authored-by: Mauricio Vanzulli <50339940+mvanzulli@users.noreply.github.com>
mvanzulli
reviewed
Oct 12, 2024
Co-authored-by: Mauricio Vanzulli <50339940+mvanzulli@users.noreply.github.com>
mvanzulli
reviewed
Oct 12, 2024
|
My email is mcvanzulli@gmail.com, feel free to send me an email so we can have chat 👍🏼 |
Co-authored-by: Mauricio Vanzulli <50339940+mvanzulli@users.noreply.github.com>
mvanzulli
requested changes
Oct 13, 2024
Co-authored-by: Mauricio Vanzulli <50339940+mvanzulli@users.noreply.github.com>
mvanzulli
reviewed
Oct 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #509 +/- ##
==========================================
+ Coverage 82.50% 83.34% +0.84%
==========================================
Files 45 45
Lines 1823 1819 -4
==========================================
+ Hits 1504 1516 +12
+ Misses 319 303 -16 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMHO, the fixes are already self-explainable.