scripts/symbolize.py: accept -d <ELF_file> in addition to -d <dir> #1766
Conversation
|
Ping? |
scripts/symbolize.py
Outdated
| @@ -94,6 +95,8 @@ def get_elf(self, elf_or_uuid): | |||
| if not elf_or_uuid.endswith('.elf'): | |||
| elf_or_uuid += '.elf' | |||
| for d in self._dirs: | |||
| if d.endswith(elf_or_uuid) and glob.glob(d): | |||
There was a problem hiding this comment.
Maybe I misunderstood what you was trying to do with glob.glob(d), but in case if it is a verification of file existence, maybe it's better to use d.is_file() (more obvious)?
There was a problem hiding this comment.
Correct. That would be os.path.isfile(d), but then we would need import os, I'm not sure it is worth it. Would you prefer that? I'm fine with both ways.
There was a problem hiding this comment.
@jforissier sorry for suggesting d.is_file(), found that it's possible to use it in python 3 only (where OOP-friendly pathlib exists). I'm fine with both ways also, but IMHO usage of os.path.isfile(d) will help easily understand what this code supposed to do (at least for me :) )
Anyway:
Reviewed-by: Igor Opaniuk <igor.opaniuk@linaro.org>
The -d option of symbolize.py normally expects one or more directories, where the script will look for ELF files (TEE or TA, depending on the input dump). For convenience, let's also accept paths to the actual ELF files. Previously, the script would just ignore file arguments and silently fail to resolve stack traces. Reported-by: Lijianhui <airbak.li@hisilicon.com> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by: Igor Opaniuk <igor.opaniuk@linaro.org>
jforissier
force-pushed
the
symbolize-d-file
branch
from
bb28425
to
25da1e5
Compare
The -d option of symbolize.py normally expects one or more directories,
where the script will look for ELF files (TEE or TA, depending on the
input dump). For convenience, let's also accept paths to the actual ELF
files. Previously, the script would just ignore file arguments and
silently fail to resolve stack traces.
Reported-by: Lijianhui airbak.li@hisilicon.com
Signed-off-by: Jerome Forissier jerome.forissier@linaro.org