Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose keywords in EclipseState #1089

Open
pgdr opened this issue Jun 14, 2017 · 4 comments
Open

Expose keywords in EclipseState #1089

pgdr opened this issue Jun 14, 2017 · 4 comments

Comments

@pgdr
Copy link
Contributor

pgdr commented Jun 14, 2017

The following keywords should be exposed from EcliseState in one way or another in the attempt of removing exposure of Deck out of parser.

  • NOGRAV
  • THPRES (only to check if threshold pressures are enabled or not)
  • EQUIL (ditto)
  • ROCK

See discussion in OPM/opm-models#189

@joakim-hove
Copy link
Member

@andlaus:

EQUIL:

bool has_equil = eclState.getInitConfig().hasEquil( );

THPRES:

bool has_thpres = eclState.getSimulationConfig( ).hasThresholdPressure();

ROCK: (slightly uncertain on this one ...)

bool has_rock = eclState.getTableManager( ).hasTables("ROCK");

NOGRAV is not in any way internalized in EclipseState.

@andlaus
Copy link
Contributor

andlaus commented Jun 14, 2017

yeah, I thought that most of this was somehow accessible. finding out which sub-object of EclipseState provides that information is non-trivial, don't you agree?

@joakim-hove
Copy link
Member

finding out which sub-object of EclipseState provides that information is non-trivial, don't you agree?

Well - I don't agree, but that is probably not very relevant.

@andlaus
Copy link
Contributor

andlaus commented Jun 14, 2017

Well - I don't agree, but that is probably not very relevant.

you probably don't agree because you know every obscure corner of this code. This is not the case for me anymore, so I have problems with this. Anyway, I agree that this has only limited relevance.

On a related matter: how to I get the rock parameters out of the RockTable object? (this is the only keyword which is presently not purely used as flag in the EclProblem)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants