Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive timestep control issue between --continue-on-convergence-error and --min-time-step-size #5371

Open
locture opened this issue May 22, 2024 · 0 comments

Comments

@locture
Copy link
Contributor

locture commented May 22, 2024

Running models with both --continue-on-convergence-error=true and a given --min-time-step-size (say, --min-time-step-size=1) can cause conflicts and unexpected terminations.

The problem occurs in the following scenario:

  1. Simulation started normally.
  2. Timestep increased to something larger than initial, say, 3 days.
  3. Cannot converge now, so timestep is chopped to something smaller again.
  4. Still fails to converge. So the timestep is chopped for another time and it becomes smaller than --min-time-step-size=1 day.

In the scenario above, by setting --continue-on-convergence-error=true I would expect the model to still continue at a timestep of 1 day even though it fails to converge here. However, the simulation actually aborted with this error message:
"Solver failed to converge but timestep "
"{} is smaller or equal to {}\n"
"which is the minimum threshold given "
"by option --solver-min-time-step\n",

It seems that there is a conflict between these logics and the --continue-on-convergence-error=true gets ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant