New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't delete CUETools DB Plugin info section in non-checksum EAC logs #6

Open

itismadness opened this issue Dec 18, 2018 · 0 comments

itismadness commented Dec 18, 2018

The logchecker currently deletes all sections that have the "CUETools" byline if it's for a log that doesn't have a checksum:

Logchecker/src/Logchecker.php

Lines 338 to 342 in b38c25a

    
           foreach ($this->Logs as $Key => $Value) { 
        
           	if (preg_match("/---- CUETools DB Plugin V.+/i", $Value)) { 
        
           		unset($this->Logs[$Key]); 
        
           	} 
        
           }

We should not be doing this, but rather leave it as part of the analyzed log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment