You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
as was brought up in #164 by @pelesh, the current names of these fields is unclear. they should be renamed to something like owns_gpu_sparsity_pattern_ and owns_gpu_nonzeroes_ (with equivalents for the cpu)
rename owns_gpu_data_, owns_gpu_values_, owns_cpu_data_, owns_cpu_values_ to the proposed names
rename the methods for setting them on Sparse
add methods for getting them?
The text was updated successfully, but these errors were encountered:
I think an easy solution would be to rename owns_*_data_ to owns_*_indices_. Since these are matrix class member variables, I think it would be clear these refer to matrix values and indices. @kswirydo, please chime in.
getRowData vs. getRowIndices? Using term "row indices" is a sloppy expression because depending on the matrix format these can be row offsets or row indices. Per @maksud, the sloppy language may be all right here because all developers would understand it.
@maksud's suggestion for using consistent language in naming methods and member variables: Use word "indices" to refer to matrix indices and offsets, use word "values" to refer to the values of the matrix nonzero elements, and word "data" to refer to the union of "indices" and "values".
setMatrixData method name may be misleading. We are assigning pointer values here and not setting matrix data. Consider renaming it to setDataPointers.
setUpdated is clear enough.
setNewValues should probably be renamed to setValues. It is simpler.
Consider changing vector method name setData to setDataPointers.
pelesh
changed the title
rename owns_gpu_data_ / owns_gpu_values_ / etc. to owns_gpu_sparsity_pattern_ / owns_gpu_nonzeroes_ / etc.
Use consistent naming scheme across matrix and vector classes
Oct 9, 2024
as was brought up in #164 by @pelesh, the current names of these fields is unclear. they should be renamed to something like
owns_gpu_sparsity_pattern_
andowns_gpu_nonzeroes_
(with equivalents for the cpu)owns_gpu_data_
,owns_gpu_values_
,owns_cpu_data_
,owns_cpu_values_
to the proposed namesSparse
The text was updated successfully, but these errors were encountered: