Skip to content

Commit a6ed422

Browse files
committed
Updates image versions and actions
1 parent e028eed commit a6ed422

File tree

4 files changed

+12
-13
lines changed

4 files changed

+12
-13
lines changed

.github/workflows/pr.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
runs-on: ubuntu-latest
2424
strategy:
2525
matrix:
26-
php-versions: [ '8.1' ]
26+
php-versions: [ '8.3' ]
2727
dependency-version: [ prefer-lowest, prefer-stable ]
2828
steps:
2929
- uses: actions/checkout@master
@@ -55,7 +55,7 @@ jobs:
5555
runs-on: ubuntu-latest
5656
strategy:
5757
matrix:
58-
php-versions: [ '8.1' ]
58+
php-versions: [ '8.3' ]
5959
dependency-version: [ prefer-lowest, prefer-stable ]
6060
steps:
6161
- uses: actions/checkout@master
@@ -88,7 +88,7 @@ jobs:
8888
runs-on: ubuntu-latest
8989
strategy:
9090
matrix:
91-
php-versions: [ '8.1' ]
91+
php-versions: [ '8.3' ]
9292
dependency-version: [ prefer-lowest, prefer-stable ]
9393
steps:
9494
- uses: actions/checkout@master
@@ -113,7 +113,7 @@ jobs:
113113
run: |
114114
# We need a Drupal project to run drupal-check (cf. https://github.com/mglaman/drupal-check#usage)
115115
# Install Drupal
116-
composer --no-interaction create-project drupal/recommended-project:^9 --stability=dev drupal
116+
composer --no-interaction create-project drupal/recommended-project:^10 --stability=dev drupal
117117
# Copy our module source code into the Drupal module folder.
118118
mkdir -p drupal/web/modules/contrib/os2forms_sync
119119
cp -r os2forms_sync.* composer.json src drupal/web/modules/contrib/os2forms_sync

CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ Versioning](https://semver.org/spec/v2.0.0.html).
1111

1212
### Updated
1313

14-
1514
## [1.2.1]
1615

1716
- Update GitHub workflows runner images

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,16 +32,16 @@ drush os2forms-sync:import --help
3232
## Coding standards
3333

3434
```sh
35-
docker run --rm --interactive --tty --volume ${PWD}:/app itkdev/php8.1-fpm:latest composer install
36-
docker run --rm --interactive --tty --volume ${PWD}:/app itkdev/php8.1-fpm:latest composer coding-standards-check
35+
docker run --rm --interactive --tty --volume ${PWD}:/app itkdev/php8.3-fpm:latest composer install
36+
docker run --rm --interactive --tty --volume ${PWD}:/app itkdev/php8.3-fpm:latest composer coding-standards-check
3737

38-
docker run --rm --interactive --tty --volume ${PWD}:/app node:18 yarn --cwd /app install
39-
docker run --rm --interactive --tty --volume ${PWD}:/app node:18 yarn --cwd /app coding-standards-check
38+
docker run --rm --interactive --tty --volume ${PWD}:/app node:20 yarn --cwd /app install
39+
docker run --rm --interactive --tty --volume ${PWD}:/app node:20 yarn --cwd /app coding-standards-check
4040
```
4141

4242
## Code analysis
4343

4444
```sh
45-
docker run --rm --interactive --tty --volume ${PWD}:/app itkdev/php8.1-fpm:latest composer install
46-
docker run --rm --interactive --tty --volume ${PWD}:/app itkdev/php8.1-fpm:latest composer code-analysis
45+
docker run --rm --interactive --tty --volume ${PWD}:/app itkdev/php8.3-fpm:latest composer install
46+
docker run --rm --interactive --tty --volume ${PWD}:/app itkdev/php8.3-fpm:latest composer code-analysis
4747
```

src/Controller/WebformController.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ public function index(): array {
126126
$form = $this->webformHelper->getSubmissionForm($attributes['elements']);
127127
// Make sure that the form cannot be submitted (hopefully).
128128
$form['#attributes']['onsubmit'] = 'return false';
129-
$renderedForm = $this->renderer->renderPlain($form);
129+
$renderedForm = $this->renderer->renderInIsolation($form);
130130
}
131131
catch (\Throwable $t) {
132132
$form = [
@@ -137,7 +137,7 @@ public function index(): array {
137137
],
138138
],
139139
];
140-
$renderedForm = $this->renderer->renderPlain($form);
140+
$renderedForm = $this->renderer->renderInIsolation($form);
141141
}
142142

143143
$sourceUrl = $webform->sourceUrl;

0 commit comments

Comments
 (0)