Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation warnings in system tests #1632

Closed
johrstrom opened this issue Nov 30, 2021 · 3 comments
Closed

deprecation warnings in system tests #1632

johrstrom opened this issue Nov 30, 2021 · 3 comments
Assignees
Labels
area/tech debt area/testing bug Existing functionality not working as expected
Milestone

Comments

@johrstrom
Copy link
Contributor

johrstrom commented Nov 30, 2021

System tests currently have these deprecation warnings.

2021-11-30 10:57:55 WARN Selenium [DEPRECATION] [:browser_options] :options as a parameter for driver initialization is deprecated. Use :capabilities with an Array of value capabilities/options if necessary instead.
2021-11-30 10:57:59 WARN Selenium [DEPRECATION] Manager#logs is deprecated. Use Chrome::Driver#logs instead.

┆Issue is synchronized with this Asana task by Unito

@johrstrom johrstrom added this to the 2.1 milestone Nov 30, 2021
@sync-by-unito sync-by-unito bot assigned Oglopf and unassigned Oglopf Feb 28, 2022
@Oglopf
Copy link
Contributor

Oglopf commented Mar 22, 2022

The first warning has a closed issue here: teamcapybara/capybara#2511

  • recommended to ignore until next release of capybara when this will be addressed
  • fix is already in their main here

The second issue does not have any open issues that I could find, and strangely I don't even see that method listed when looking at the API for Selenium:

Let's keep this open until the release of Capybara is cut, then we can update and see what the logging issue gives then.

@johrstrom
Copy link
Contributor Author

Related to #1387 I guess? I tried it once, and it's a whole thing with geckodriver mozilla/geckodriver#284.

My guess for the logging thing is to actually check if we're using chrome and then use Chrome::Driver#logs. Even if you can't see the documentation for it, does it work using Chrome::Driver#logs?

@lukew3 lukew3 added the bug Existing functionality not working as expected label Jun 30, 2022
@johrstrom
Copy link
Contributor Author

I fixed this at some point when I upgraded those libraries. Looking at the most recent CI activity confirms it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tech debt area/testing bug Existing functionality not working as expected
Projects
None yet
Development

No branches or pull requests

4 participants