Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K8s bc cards show 0 nodes #4073

Open
johrstrom opened this issue Jan 13, 2025 · 1 comment · May be fixed by #4074
Open

K8s bc cards show 0 nodes #4073

johrstrom opened this issue Jan 13, 2025 · 1 comment · May be fixed by #4074
Labels
bug Existing functionality not working as expected component/batch_connect
Milestone
4.0

Comments

@johrstrom
Copy link
Contributor

Similar to #4057 kubernetes batch connect cards incorrectly show 0 nodes.

image
@johrstrom johrstrom added bug Existing functionality not working as expected component/batch_connect labels Jan 13, 2025
@johrstrom johrstrom added this to the 4.0 milestone Jan 13, 2025
@johrstrom johrstrom linked a pull request Jan 13, 2025 that will close this issue
Open
@johrstrom
Copy link
Contributor Author

Turns out the old behaviour was to simply not show nodes at all.

image

This is because this was behind an unless block.

ondemand/apps/dashboard/app/helpers/batch_connect/sessions_helper.rb

Line 21 in 1973d47

status << content_tag(:span, pluralize(num_nodes, "node"), class: "badge badge-#{status_context(session)} badge-pill") unless num_nodes.zero?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Existing functionality not working as expected component/batch_connect
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

only show nodes if it's positive OSC/ondemand
1 participant
@johrstrom