Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LHA and likely systemd don't respond to native arrays #763

Open
johrstrom opened this issue Jul 15, 2022 · 0 comments
Open

LHA and likely systemd don't respond to native arrays #763

johrstrom opened this issue Jul 15, 2022 · 0 comments

Comments

@johrstrom
Copy link
Contributor

johrstrom commented Jul 15, 2022

Most adapters use an array for #native attributes. linux_host and likely systemd use hashes.

So when someone uses an array (like the dashboard's test:jobs rake task does) it throws this runtime error.

rake aborted!
TypeError: no implicit conversion of String into Integer
/users/PZS0714/johrstrom/ondemand/src/apps/dashboard/vendor/bundle/ruby/2.7.0/gems/ood_core-0.20.0/lib/ood_core/job/adapters/linux_host/launcher.rb:97:in `[]'
/users/PZS0714/johrstrom/ondemand/src/apps/dashboard/vendor/bundle/ruby/2.7.0/gems/ood_core-0.20.0/lib/ood_core/job/adapters/linux_host/launcher.rb:97:in `submit_host'
/users/PZS0714/johrstrom/ondemand/src/apps/dashboard/vendor/bundle/ruby/2.7.0/gems/ood_core-0.20.0/lib/ood_core/job/adapters/linux_host/launcher.rb:60:in `start_remote_session'
/users/PZS0714/johrstrom/ondemand/src/apps/dashboard/vendor/bundle/ruby/2.7.0/gems/ood_core-0.20.0/lib/ood_core/job/adapters/linux_host.rb:83:in `submit'These should be casting to hashes as arrays are more popular.

┆Issue is synchronized with this Asana task by Unito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant