Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up sqlite3 further in CMake #4004

Closed
ErixenCruz opened this issue Jan 15, 2024 · 1 comment · Fixed by #4007
Closed

Clean up sqlite3 further in CMake #4004

ErixenCruz opened this issue Jan 15, 2024 · 1 comment · Fixed by #4007

Comments

@ErixenCruz
Copy link
Contributor

#3987 changed the CMake to link to the explicit target SQLite::SQLite3 and find SQLite3, which makes use of CMake's built-in FindSQLite3 script instead of PROJ's.

@mwtoews mentioned in the CMake 3.16 upgrade PR that there are some Sqlite3 configuration variables that should probably be adjusted or deprecated. #3997 (comment). Reading about find_path, which is called in the built-in FindSQLite3 script, the configuration variables might just have to be mapped to SQLite3_ROOT. A CMake expert may chime in here.

The other thing is that we can probably remove PROJ's FindSqlite3 and rely entirely on built-in CMake.

@mwtoews
Copy link
Member

mwtoews commented Jan 15, 2024

Thanks @ErixenCruz , that's correct, I'm planning to replace cmake/FindSqlite3.cmake with the FindSQLite3 built-in. Everybody [usually] wins when bespoke/custom modules are replaced with better-known built-in modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants