[Bug] Should grass.script expose ScriptError from wildcard imports?

[echoix]

Describe the bug

https://github.com/OSGeo/grass/blob/3b5184f3454c69afdf2844479403a5d8ef5d24e0/python/grass/script/__init__.py now lists the names for wildcard imports, in the __all__ variable.
The text ScriptError is found 55 times. In some calls in gui, it is used like

• gs.ScriptError multiple times
• gcore.ScriptError in gui/wxpython/animation/dialogs.py
• grass.ScriptError in gui/wxpython/gui_core/forms.py, where grass is from grass.script import core as grass
• ScriptError in gui/wxpython/core/toolboxes.py and more, where from grass.exceptions import ScriptError, CalledModuleError is used

What should be done? Technically, we show that ScriptError isn't listed from grass.script in the init file.

[echoix]

@petrasovaa Maybe you'd have an opinion on this

[petrasovaa]

I think from grass.exceptions import ScriptError is the correct way, no?

[echoix]

I think from grass.exceptions import ScriptError is the correct way, no?

That's what I used in #4841. I also think it should be in the GUI code too. It might also help in reducing the circular imports noticed by Pylint 3 (but disabled for now in order to be able to upgrade).

[echoix]

And for the usages of ScriptError imported from grass.script.core (found in some GUI code), should they be changed to the correct import? As currently, they rely on a side effect of having ScriptError imported inside grass.script.core (for grass.script.core's purposes, but not declared)

[petrasovaa]

And for the usages of ScriptError imported from grass.script.core (found in some GUI code), should they be changed to the correct import? As currently, they rely on a side effect of having ScriptError imported inside grass.script.core (for grass.script.core's purposes, but not declared)

Yes I think so.

[wenzeslaus]

I'm pretty sure the variations are from before creation of grass.exceptions. We should import from where it is defined.

@arohanajit can you please make the changes? @echoix let us know if you are already working on it.

[echoix]

No I didn't work on it, but since the decision is made, it's quite straightforward to do

[arohanajit]

I'm pretty sure the variations are from before creation of grass.exceptions. We should import from where it is defined.

@arohanajit can you please make the changes? @echoix let us know if you are already working on it.

I'll standardize across all the files.

[echoix]

Thanks!