Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog Post (2017-04-26): Hello World #1

Open
mikeeus opened this issue Apr 28, 2017 · 5 comments
Open

Blog Post (2017-04-26): Hello World #1

mikeeus opened this issue Apr 28, 2017 · 5 comments

Comments

@mikeeus
Copy link
Contributor

mikeeus commented Apr 28, 2017

http://ossdc.mikias.net/2017/04/26/hello-world/

@jatindhankhar
Copy link

@mikeeus
You are using Wordpress but we AFAIK we discussed to stay from Wordpress and other traditional CMS. My main concern is the server side code which you are uploading in this open repo. I don't think that should be the way.
Let's discuss this thoroughly then only pull this off
@mslavescu

@mslavescu
Copy link
Member

mslavescu commented Apr 29, 2017

@jatindhankhar you are right, we shouldn't use wordpress for serving as we prior discussed, the idea here is to use it only for editing, by OSSDC.org authors, then push the article to this repo as static content for serving through GitHub pages.

The comments section would be handled also through GitHub comments, by creating an associated issue on this repo, tagged as blog comment, for each article.

Once an author publishes an article on the (edit side of the) blog, will need to create an issue here and refer it at the end of the article to invite readers to comment.

See for example my first post:

http://ossdc.mikias.net/2017/04/29/a-new-ossdc-org-mvp-to-build-a-smart-dash-camera-using-android-phones/

This way we simplify the collaboration and make use of all Github free resources.

Once a commenter has a GitHub account it is easier to contribute to the code also.

@jatindhankhar
Copy link

jatindhankhar commented Apr 30, 2017

@mslavescu Okay but Github pages cannot serve wordpress pages directly, also there is no need to expose server side code,database dump and php files here.
You are also exposing sensitive information, take a look at following code
https://github.com/OSSDC/blog.ossdc.org/blob/master/db/database_dump.sql#L437

INSERT INTO `wp_users` VALUES (1,'mikias','$P$Bp4xyrkn/3VlAdv/QOKgfsFOeuO.cd0','mikias','itsmikias@gmail.com','','2017-04-27 04:57:52','',0,'mikias');

@mikeeus
Copy link
Contributor Author

mikeeus commented Apr 30, 2017

@jatindhankhar You're absolutely correct, I'm going to delete the server side code from the repo and the only thing that will be in there is statically generated code which will work on Github pages.

@mikeeus
Copy link
Contributor Author

mikeeus commented Apr 30, 2017

By the way the php files and db dump are from a one off wp site I made locally so none of the info applies to the website currently online.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants