Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for the operator #399

Closed
m-yosefpor opened this issue Dec 12, 2022 · 2 comments · Fixed by #576
Closed

Adding tests for the operator #399

m-yosefpor opened this issue Dec 12, 2022 · 2 comments · Fixed by #576
Assignees
Labels
enhancement New feature or request

Comments

@m-yosefpor
Copy link

Is your feature request related to a problem? Please describe.

There are new kind of bugs which are introduced into new version releases, which can be prevented and figured out before code release. For example #394 panic issue which happens when there is not a storage section in redis manifest (for redis with persistent disabled). Although #395 fixed the issue, these kind of bugs might be reintroduced again in future releases.
Describe the solution you'd like

Adding tests for the operator and having a pipeline which is run in github actions and making sure the pipeline is passed for each release. Tests can be completed overtime, and encompass most of the operator logic, and can prevent many kind of issues (panics, logical issues, etc)

Describe alternatives you've considered

What version of redis-operator are you using?

redis-operator version: 0.13.0

Additional context

I'll send a few PRs to add some tests and add github action pipelines for testing the operator

@m-yosefpor m-yosefpor added the enhancement New feature or request label Dec 12, 2022
@iamabhishek-dubey
Copy link
Member

@m-yosefpor have you started working on writing e2e test cases?

@m-yosefpor
Copy link
Author

m-yosefpor commented Jan 16, 2023

@m-yosefpor have you started working on writing e2e test cases?

Not yet. I have a cramped work schedule these days. I have plans to start it in a few weeks. Feel free to take over this if you can contribute sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants