Fix case request is already signed #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So what I did for now is comment out the fix. Modify the settings to actually sign the response. Then wrote a test to verify the 500. That test will fail w/ 500 since the code is commented out. You can uncomment the fix and see the test pass (i.e. fixes the bug). Issue I'm running into is inline modifying the IDP config for that test and that test only. Modifying the actual settings file vs. in the test via a fixture causes other tests to fail. |
Amertz08
changed the title
|
So I am not running into any issues running the tests locally. Not sure what the issue in the build process is. |
|
Can this PR be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121