Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review comments H1L021 PR # 46 - Python Script #48

Closed
Cyb3rPandaH opened this issue Mar 12, 2022 · 2 comments
Closed

Review comments H1L021 PR # 46 - Python Script #48

Cyb3rPandaH opened this issue Mar 12, 2022 · 2 comments
Assignees

Comments

@Cyb3rPandaH
Copy link
Collaborator

Comment in PR #46 @H1L021
Regarding the python script. It is really cool :D I was thinking on doing something similar LOL. I just tested it and it works. Just a quick question: Would the script work when creating relationships in a year different than 2022?

@Cyb3rPandaH Cyb3rPandaH self-assigned this Mar 12, 2022
@Cyb3rSn0rlax
Copy link
Contributor

Actually, it won't and I put as a To-Do task at the end of my PR.
I will create a new PR to add current year instead of 2022

@Cyb3rPandaH
Copy link
Collaborator Author

Hi @H1L021 I just modified your PR with the update to the script.

I am basically working with a dictionary instead of a list.
The keys of the dictionary are the years, and the values of the dictionary are lists with the numbers used for the ID.

As we discussed before, I added this script to the ossemDM.py script so we can now add the ID to new yaml files after merging PR's. 🍻

Even though your script is now part of the ossemDM.py script, please do not delete the updated generate_uuid. py script. 🙏 I will archive the script within the project later. We might need to use it in the future 👍

I am closing this issue. Thank you again 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants