Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4.2 Salt size recommendation #994

Closed
ThunderSon opened this issue May 11, 2021 · 4 comments
Closed

2.4.2 Salt size recommendation #994

ThunderSon opened this issue May 11, 2021 · 4 comments
Assignees
Labels
1) Discussion ongoing Issue is opened and assigned but no clear proposal yet

Comments

@ThunderSon
Copy link
Contributor

In 2.4.2, it is mentioned to have a salt of 32 bits, which is barely 4 bytes.

I believe this should be raised to 128 bits, to ensure that it is random enough across the DB and across other used DBs.

The best thing would be to match the hash length and go beyond it, but that might be too much.

@jmanico
Copy link
Member

jmanico commented May 11, 2021 via email

@Sjord
Copy link
Contributor

Sjord commented Jun 3, 2021

See also #1002.

@jmanico
Copy link
Member

jmanico commented Jun 3, 2021

#1000

@elarlang elarlang added the 1) Discussion ongoing Issue is opened and assigned but no clear proposal yet label Jul 20, 2021
@jmanico
Copy link
Member

jmanico commented Sep 24, 2021

Salts have been removed from 2.4 making this issue moot.

@jmanico jmanico closed this as completed Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1) Discussion ongoing Issue is opened and assigned but no clear proposal yet
Projects
None yet
Development

No branches or pull requests

4 participants