Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a null check on profile pic #141

Merged
merged 3 commits into from
Dec 23, 2022
Merged

Add a null check on profile pic #141

merged 3 commits into from
Dec 23, 2022

Conversation

letsintegreat
Copy link
Contributor

Closes #140

I have added a null check on profile pic to save it from crashing. Now it uses a default profile pic in case there is none:

This is how the app looks like with the default profile pic:
Screenshot_1670960833

Copy link
Contributor

@fredfalcon fredfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the image to assets please?

@letsintegreat
Copy link
Contributor Author

Can you add the image to assets please?

Yes, that makes more sense. On it

@letsintegreat
Copy link
Contributor Author

Can you add the image to assets please?

I have addressed this request, please review.

@fredfalcon fredfalcon enabled auto-merge December 18, 2022 13:40
@fredfalcon fredfalcon merged commit 4d5841b into OWASP-BLT:main Dec 23, 2022
@letsintegreat letsintegreat deleted the issue-140-profile-pic branch December 23, 2022 14:01
DonnieBLT pushed a commit that referenced this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Null check operator used on a null value" when trying to open the profile page.
2 participants