sonar fixes

Author: SUPERGAMERDIV

backend/tests/apps/owasp/management/commands/owasp_update_project_health_metrics_test.py

@@ -226,15 +226,21 @@ def test_update_official_levels_level_mapping(self):
         ]
 
         for official_level, expected_mapped in test_cases:
-            with patch(PROJECT_FILTER_PATCH) as mock_filter:
+            with patch(PROJECT_FILTER_PATCH) as mock_filter, \
+                 patch(PROJECT_BULK_SAVE_PATCH) as mock_bulk_save:
 
                 mock_filter.return_value = [project]
                 project.project_level_official = "other"  # Reset
 
                 official_levels = {TEST_PROJECT_NAME: official_level}
-                self.command.update_official_levels(official_levels)
+                updated_count = self.command.update_official_levels(official_levels)
 
                 assert project.project_level_official == expected_mapped
+                if expected_mapped != "other":  # Only count as update if level changed
+                    assert updated_count == 1
+                    mock_bulk_save.assert_called_once()
+                else:
+                    assert updated_count == 0
 
     @patch('requests.get')
     def test_handle_with_official_levels_integration(self, mock_get):

backend/tests/apps/owasp/management/commands/project_level_compliance_integration_test.py

@@ -225,9 +225,9 @@ def test_api_failure_handling(self, mock_get):
 
         project = self.create_mock_project("Test Project", "lab", "lab")
 
-        with patch("apps.owasp.models.project.Project.objects.filter") as mock_projects, \
-             patch("apps.owasp.models.project_health_metrics.ProjectHealthMetrics.bulk_save"), \
-             patch("sys.stdout", new=self.stdout):
+        with patch(PROJECT_FILTER_PATCH) as mock_projects, \
+             patch(METRICS_BULK_SAVE_PATCH), \
+             patch(STDOUT_PATCH, new=self.stdout):
 
             mock_projects.return_value = [project]
 
@@ -245,9 +245,9 @@ def test_skip_official_levels_flag(self):
         """Test that --skip-official-levels flag works correctly."""
         project = self.create_mock_project("Test Project", "lab", "flagship")
 
-        with patch("apps.owasp.models.project.Project.objects.filter") as mock_projects, \
-             patch("apps.owasp.models.project_health_metrics.ProjectHealthMetrics.bulk_save"), \
-             patch("sys.stdout", new=self.stdout):
+        with patch(PROJECT_FILTER_PATCH) as mock_projects, \
+             patch(METRICS_BULK_SAVE_PATCH), \
+             patch(STDOUT_PATCH, new=self.stdout):
 
             mock_projects.return_value = [project]