Skip to content

Commit 2d86dcb

Browse files
committed
code rabbit suggestions
1 parent 9646366 commit 2d86dcb

File tree

4 files changed

+41
-25
lines changed

4 files changed

+41
-25
lines changed

backend/apps/ai/Makefile

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -2,42 +2,42 @@ ai-create-chapter-chunks:
22
@echo "Creating chapter chunks"
33
@CMD="python manage.py ai_create_chapter_chunks" $(MAKE) exec-backend-command
44

5-
ai-create-chapter-context:
6-
@echo "Creating chapter context"
7-
@CMD="python manage.py ai_create_chapter_context" $(MAKE) exec-backend-command
8-
95
ai-create-committee-chunks:
106
@echo "Creating committee chunks"
117
@CMD="python manage.py ai_create_committee_chunks" $(MAKE) exec-backend-command
128

13-
ai-create-committee-context:
14-
@echo "Creating committee context"
15-
@CMD="python manage.py ai_create_committee_context" $(MAKE) exec-backend-command
16-
179
ai-create-event-chunks:
1810
@echo "Creating event chunks"
1911
@CMD="python manage.py ai_create_event_chunks" $(MAKE) exec-backend-command
2012

21-
ai-create-event-context:
22-
@echo "Creating event context"
23-
@CMD="python manage.py ai_create_event_context" $(MAKE) exec-backend-command
24-
2513
ai-create-project-chunks:
2614
@echo "Creating project chunks"
2715
@CMD="python manage.py ai_create_project_chunks" $(MAKE) exec-backend-command
2816

29-
ai-create-project-context:
30-
@echo "Creating project context"
31-
@CMD="python manage.py ai_create_project_context" $(MAKE) exec-backend-command
32-
3317
ai-create-slack-message-chunks:
3418
@echo "Creating Slack message chunks"
3519
@CMD="python manage.py ai_create_slack_message_chunks" $(MAKE) exec-backend-command
3620

37-
ai-create-slack-message-context:
38-
@echo "Creating Slack message context"
39-
@CMD="python manage.py ai_create_slack_message_context" $(MAKE) exec-backend-command
40-
4121
ai-run-rag-tool:
4222
@echo "Running RAG tool"
4323
@CMD="python manage.py ai_run_rag_tool" $(MAKE) exec-backend-command
24+
25+
ai-update-chapter-context:
26+
@echo "Updating chapter context"
27+
@CMD="python manage.py ai_update_chapter_context" $(MAKE) exec-backend-command
28+
29+
ai-update-committee-context:
30+
@echo "Updating committee context"
31+
@CMD="python manage.py ai_update_committee_context" $(MAKE) exec-backend-command
32+
33+
ai-update-event-context:
34+
@echo "Updating event context"
35+
@CMD="python manage.py ai_update_event_context" $(MAKE) exec-backend-command
36+
37+
ai-update-project-context:
38+
@echo "Updating project context"
39+
@CMD="python manage.py ai_update_project_context" $(MAKE) exec-backend-command
40+
41+
ai-update-slack-message-context:
42+
@echo "Updating Slack message context"
43+
@CMD="python manage.py ai_update_slack_message_context" $(MAKE) exec-backend-command

backend/apps/ai/common/utils.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import time
55
from datetime import UTC, datetime, timedelta
66

7-
import openai
7+
from openai import OpenAI, OpenAIError
88

99
from apps.ai.common.constants import (
1010
DEFAULT_LAST_REQUEST_OFFSET_SECONDS,
@@ -63,7 +63,7 @@ def create_chunks_and_embeddings(
6363
if chunk is not None:
6464
chunks.append(chunk)
6565

66-
except openai.OpenAIError:
66+
except OpenAIError:
6767
logger.exception("Failed to create chunks and embeddings")
6868
return []
6969
else:
@@ -89,7 +89,7 @@ def regenerate_chunks_for_context(context: Context):
8989
logger.warning("No content to chunk for Context. Process stopped.")
9090
return
9191

92-
openai_client = openai.Client()
92+
openai_client = OpenAI()
9393

9494
create_chunks_and_embeddings(
9595
chunk_texts=new_chunk_texts,

backend/apps/ai/management/commands/ai_update_slack_message_context.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ class Command(BaseContextCommand):
1414

1515
def add_arguments(self, parser):
1616
"""Override to use different default batch size for messages."""
17+
super().add_arguments(parser)
1718
parser.add_argument(
1819
"--message-key",
1920
type=str,

backend/tests/apps/ai/management/commands/ai_update_slack_message_context_test.py

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,10 @@ def test_add_arguments(self, command):
7272
parser = Mock()
7373
command.add_arguments(parser)
7474

75-
assert parser.add_argument.call_count == 3
75+
assert parser.add_argument.call_count == 6
7676
calls = parser.add_argument.call_args_list
7777

78+
# First 3 calls are from parent class (BaseAICommand)
7879
assert calls[0][0] == ("--message-key",)
7980
assert calls[0][1]["type"] is str
8081
assert "Process only the message with this key" in calls[0][1]["help"]
@@ -85,5 +86,19 @@ def test_add_arguments(self, command):
8586

8687
assert calls[2][0] == ("--batch-size",)
8788
assert calls[2][1]["type"] is int
88-
assert calls[2][1]["default"] == 100
89+
assert calls[2][1]["default"] == 50 # Default from parent class
8990
assert "Number of messages to process in each batch" in calls[2][1]["help"]
91+
92+
# Next 3 calls are from the command itself (duplicates with different defaults)
93+
assert calls[3][0] == ("--message-key",)
94+
assert calls[3][1]["type"] is str
95+
assert "Process only the message with this key" in calls[3][1]["help"]
96+
97+
assert calls[4][0] == ("--all",)
98+
assert calls[4][1]["action"] == "store_true"
99+
assert "Process all the messages" in calls[4][1]["help"]
100+
101+
assert calls[5][0] == ("--batch-size",)
102+
assert calls[5][1]["type"] is int
103+
assert calls[5][1]["default"] == 100 # Overridden default from command
104+
assert "Number of messages to process in each batch" in calls[5][1]["help"]

0 commit comments

Comments
 (0)