Skip to content

Commit 3f24154

Browse files
Fixed: Added type to all buttons that are not meant for form submissions.
1 parent f542220 commit 3f24154

16 files changed

+22
-1
lines changed

frontend/src/components/LoginPageContent.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ const LoginPageContent: FC<LoginPageContentProps> = ({ isGitHubAuthEnabled }) =>
7171
</p>
7272

7373
<button
74+
type="button"
7475
onClick={() => signIn('github', { callbackUrl: '/' })}
7576
className="flex w-full items-center justify-center gap-2 rounded-lg bg-black px-4 py-2 font-medium text-white transition-colors hover:bg-gray-900/90"
7677
>

frontend/src/components/MenteeIssues.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@ const MenteeIssues: React.FC<MenteeIssuesProps> = ({ openIssues, closedIssues, m
117117
{/* Tab Navigation */}
118118
<div className="mb-4 flex border-b border-gray-200">
119119
<button
120+
type="button"
120121
onClick={() => setActiveTab('open')}
121122
className={`border-b-2 px-4 py-2 text-sm font-medium transition-colors ${
122123
activeTab === 'open'
@@ -128,6 +129,7 @@ const MenteeIssues: React.FC<MenteeIssuesProps> = ({ openIssues, closedIssues, m
128129
Open Issues ({openIssues.length})
129130
</button>
130131
<button
132+
type="button"
131133
onClick={() => setActiveTab('closed')}
132134
className={`border-b-2 px-4 py-2 text-sm font-medium transition-colors ${
133135
activeTab === 'closed'

frontend/src/components/Milestones.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ const Milestones: React.FC<ProjectMilestonesProps> = ({
5656
<div className="flex flex-1 items-center overflow-hidden">
5757
<FontAwesomeIcon icon={faFolderOpen} className="mr-2 h-5 w-4" />
5858
<button
59+
type="button"
5960
className="cursor-pointer overflow-hidden text-ellipsis whitespace-nowrap text-gray-600 hover:underline dark:text-gray-400"
6061
onClick={() =>
6162
router.push(

frontend/src/components/ModuleList.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ const ModuleList: React.FC<ModuleListProps> = ({ modules }) => {
2121
const displayText = module.length > 50 ? `${module.slice(0, 50)}...` : module
2222
return (
2323
<button
24+
type="button"
2425
key={`${module}-${index}`}
2526
className="rounded-lg border border-gray-400 px-3 py-1 text-sm transition-all duration-200 ease-in-out hover:scale-105 hover:bg-gray-200 dark:border-gray-300 dark:hover:bg-gray-700"
2627
title={module.length > 50 ? module : undefined}

frontend/src/components/MultiSearch.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -274,6 +274,7 @@ const MultiSearchBar: React.FC<MultiSearchBarProps> = ({
274274
}`}
275275
>
276276
<button
277+
type="button"
277278
onClick={() => handleSuggestionClick(hit, suggestion.indexName)}
278279
className="flex w-full cursor-pointer items-center overflow-hidden border-none bg-transparent p-0 text-left"
279280
>

frontend/src/components/NavDropDown.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ export default function NavDropdown({ link, pathname }: NavDropDownProps) {
4040
)}
4141
>
4242
<button
43+
type="button"
4344
className="flex items-center gap-2 whitespace-nowrap"
4445
onClick={() => setIsOpen((prev) => !prev)}
4546
aria-expanded={isOpen}

frontend/src/components/RecentIssues.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ const RecentIssues: React.FC<RecentIssuesProps> = ({ data, showAvatar = true })
3636
<div className="flex flex-1 items-center overflow-hidden">
3737
<FontAwesomeIcon icon={faFolderOpen} className="mr-2 h-5 w-4" />
3838
<button
39+
type="button"
3940
className="cursor-pointer overflow-hidden text-ellipsis whitespace-nowrap text-gray-600 hover:underline dark:text-gray-400"
4041
onClick={() =>
4142
router.push(

frontend/src/components/RecentPullRequests.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ const RecentPullRequests: React.FC<RecentPullRequestsProps> = ({ data, showAvata
3737
<div className="mr-4 flex flex-1 items-center overflow-hidden">
3838
<FontAwesomeIcon icon={faFolderOpen} className="mr-2 h-5 w-4" />
3939
<button
40+
type="button"
4041
className="cursor-pointer overflow-hidden text-ellipsis whitespace-nowrap text-gray-600 hover:underline dark:text-gray-400"
4142
onClick={() =>
4243
router.push(

frontend/src/components/Release.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ const Release: React.FC<ReleaseProps> = ({
7070
<div className="flex flex-1 items-center overflow-hidden">
7171
<FontAwesomeIcon icon={faFolderOpen} className="mr-2 h-5 w-4" />
7272
<button
73+
type="button"
7374
className="cursor-pointer overflow-hidden text-ellipsis whitespace-nowrap text-gray-600 hover:underline dark:text-gray-400"
7475
disabled={!release.organizationName || !release.repositoryName}
7576
onClick={() => {

frontend/src/components/RepositoryCard.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ const RepositoryItem = ({ details }: { details: RepositoryCardProps }) => {
4141
<div className="flex h-46 w-full flex-col gap-3 rounded-lg border-1 border-gray-200 p-4 shadow-xs ease-in-out hover:shadow-md dark:border-gray-700 dark:bg-gray-800">
4242
<div className="flex items-start justify-between gap-2">
4343
<button
44+
type="button"
4445
onClick={handleClick}
4546
className="min-w-0 flex-1 cursor-pointer text-start font-semibold text-blue-400 hover:underline"
4647
>

0 commit comments

Comments
 (0)