Update code

Author: arkid15r

backend/apps/api/rest/v0/event.py

@@ -20,11 +20,11 @@
 class EventBase(Schema):
     """Base schema for Event (used in list endpoints)."""
 
-    end_date: datetime
+    end_date: datetime | None = None
     key: str
     name: str
     start_date: datetime
-    url: str
+    url: str | None = None
 
 
 class Event(EventBase):
@@ -34,7 +34,7 @@ class Event(EventBase):
 class EventDetail(EventBase):
     """Detail schema for Event (used in single item endpoints)."""
 
-    description: str
+    description: str | None = None
 
 
 class EventError(Schema):

backend/apps/api/rest/v0/pagination.py

@@ -2,14 +2,14 @@
 
 from typing import Any
 
+from django.http import Http404
 from ninja import Field, Schema
 from ninja.pagination import PaginationBase
 
 
 class CustomPagination(PaginationBase):
     """Custom pagination with standardized output schema."""
 
-    # Override the default items attribute name
     items_attribute: str = "items"
 
     class Input(Schema):
@@ -33,12 +33,19 @@ def paginate_queryset(self, queryset, pagination: Input, **params):
         page = pagination.page
         page_size = pagination.page_size
 
-        # Calculate pagination
+        # Calculate pagination.
         total_count = queryset.count()
-        total_pages = (total_count + page_size - 1) // page_size  # Ceiling division
+        # Ensure total_pages is at least 1 for consistent metadata.
+        total_pages = max(1, (total_count + page_size - 1) // page_size)
+
+        # Validate that the requested page is within the valid range.
+        if page > total_pages:
+            message = f"Page {page} not found. Valid pages are 1 to {total_pages}."
+            raise Http404(message)
+
         offset = (page - 1) * page_size
 
-        # Get the page items
+        # Get the page items.
         items = list(queryset[offset : offset + page_size])
 
         return {

backend/apps/api/rest/v0/release.py

@@ -22,7 +22,7 @@ class ReleaseBase(Schema):
 
     created_at: datetime
     name: str
-    published_at: datetime
+    published_at: datetime | None = None
     tag_name: str
 
 

backend/apps/api/rest/v0/repository.py

@@ -32,7 +32,7 @@ class Repository(RepositoryBase):
 class RepositoryDetail(RepositoryBase):
     """Detail schema for Repository (used in single item endpoints)."""
 
-    description: str
+    description: str | None = None
 
 
 class RepositoryError(Schema):

backend/tests/apps/api/rest/v0/event_test.py

@@ -27,14 +27,13 @@
     ],
 )
 def test_event_serializer_validation(event_data):
-    # Create a mock object with nest_key property
-    class MockEvent:
-        def __init__(self, data):
-            for key, value in data.items():
-                setattr(self, key, value)
-            self.nest_key = data["key"]
-
-    event = EventDetail.from_orm(MockEvent(event_data))
+    event = EventDetail(
+        **{
+            **event_data,
+            "end_date": datetime.fromisoformat(event_data["end_date"]),
+            "start_date": datetime.fromisoformat(event_data["start_date"]),
+        }
+    )
 
     assert event.description == event_data["description"]
     assert event.end_date == datetime.fromisoformat(event_data["end_date"])