address bugs and inconsistencies in REST API v0 endpoints

Author: EclipseAditya

backend/apps/api/rest/v0/issue.py

@@ -89,9 +89,9 @@ def list_issues(
     if filters.state:
         issues = issues.filter(state=filters.state)
 
-    if ordering and ordering.lstrip("-") == "updated_at":
+    if ordering:
         return issues.order_by(ordering, "id")
-    return issues.order_by(ordering or "-created_at", "-updated_at", "id")
+    return issues.order_by("-created_at", "-updated_at", "id")
 
 
 @router.get(

backend/apps/api/rest/v0/milestone.py

@@ -94,9 +94,9 @@ def list_milestones(
     if filters.state:
         milestones = milestones.filter(state=filters.state)
 
-    if ordering and ordering.lstrip("-") == "updated_at":
+    if ordering:
         return milestones.order_by(ordering, "id")
-    return milestones.order_by(ordering or "-created_at", "-updated_at", "id")
+    return milestones.order_by("-created_at", "-updated_at", "id")
 
 
 @router.get(

backend/apps/api/rest/v0/release.py

@@ -90,9 +90,9 @@ def list_release(
     if filters.tag_name:
         releases = releases.filter(tag_name=filters.tag_name)
 
-    if ordering and ordering.lstrip("-") == "created_at":
+    if ordering:
         return releases.order_by(ordering, "id")
-    return releases.order_by(ordering or "-published_at", "-created_at", "id")
+    return releases.order_by("-published_at", "-created_at", "id")
 
 
 @router.get(

backend/apps/api/rest/v0/repository.py

@@ -72,9 +72,9 @@ def list_repository(
     if filters.organization_id:
         repositories = repositories.filter(organization__login__iexact=filters.organization_id)
 
-    if ordering and ordering.lstrip("-") == "updated_at":
+    if ordering:
         return repositories.order_by(ordering, "id")
-    return repositories.order_by(ordering or "-created_at", "-updated_at", "id")
+    return repositories.order_by("-created_at", "-updated_at", "id")
 
 
 @router.get(

backend/tests/apps/api/rest/v0/issue_test.py

@@ -143,7 +143,7 @@ def test_list_issues_with_custom_ordering(self, mock_objects):
         mock_objects.select_related.assert_called_once_with(
             "repository", "repository__organization"
         )
-        mock_select_related.order_by.assert_called_once_with("created_at", "-updated_at", "id")
+        mock_select_related.order_by.assert_called_once_with("created_at", "id")
         assert result == mock_ordered
 
     @patch("apps.api.rest.v0.issue.IssueModel.objects")

backend/tests/apps/api/rest/v0/milestone_test.py

@@ -115,7 +115,7 @@ def test_list_milestones_with_custom_ordering(self, mock_objects):
         mock_objects.select_related.assert_called_once_with(
             "repository", "repository__organization"
         )
-        mock_select_related.order_by.assert_called_once_with("created_at", "-updated_at", "id")
+        mock_select_related.order_by.assert_called_once_with("created_at", "id")
         assert result == mock_ordered
 
     @patch("apps.api.rest.v0.milestone.MilestoneModel.objects")

backend/tests/apps/api/rest/v0/repository_test.py

@@ -54,7 +54,7 @@ def test_list_repository_with_custom_ordering(self, mock_objects):
         result = list_repository(mock_request, filters=mock_filters, ordering="created_at")
 
         mock_objects.select_related.assert_called_once_with("organization")
-        mock_select.order_by.assert_called_once_with("created_at", "-updated_at", "id")
+        mock_select.order_by.assert_called_once_with("created_at", "id")
         assert result == mock_ordered
 
     @patch("apps.api.rest.v0.repository.RepositoryModel.objects")