Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem using aliases #19

Open
BrianMer opened this issue Oct 12, 2023 · 1 comment · May be fixed by #20
Open

Problem using aliases #19

BrianMer opened this issue Oct 12, 2023 · 1 comment · May be fixed by #20

Comments

@BrianMer
Copy link

e.g.: In the own.yaml, 'ChromeHistory' is used to reference 'ChromiumBasedBrowsersHistory' (so, 'ChromeHistory' is an alias of 'ChromiumBasedBrowsersHistory', which we can see in the webbrowser.yaml file).

In the fastir_artifacts.py, you're using GetDefinitionByName() method, not GetDefinitionByAlias(), so only names are accepted.

Could this be possible to modify your YAML to correct the issue, or modify your Python code to support aliases?
@gregorygui
Copy link
Collaborator

Hi,

Thanks for the report, we're working on it.

@gregorygui gregorygui linked a pull request Oct 18, 2023 that will close this issue
Upgrades + change to GetDefinitionByAlias #20
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrades + change to GetDefinitionByAlias OWNsecurity/fastir_artifacts
2 participants
@gregorygui @BrianMer