Adds support for the Newlib-Nano Standard Library #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For MCUs with very little flash, the Nano library is more suitable. - This change supports building with the GCC nano stdlib, simply by linking STM32::Nano library in cmake.
|
Great contribution, can you add this modification to the Readme.md file too? An undocumented feature is no feature at all 😄 |
|
There must be a way to check that we are not trying to link both STM32::NoSys STM32::Nano, since those does not make sense together. |
Hish15
reviewed
Dec 29, 2020
cmake/stm32/common.cmake
Outdated
Comment on lines
233
to
238
| if(NOT (TARGET STM32::Nano)) | ||
| add_library(STM32::Nano INTERFACE IMPORTED) | ||
| target_compile_options(STM32::Nano INTERFACE $<$<C_COMPILER_ID:GNU>:--specs=nano.specs>) | ||
| target_link_options(STM32::Nano INTERFACE $<$<C_COMPILER_ID:GNU>:--specs=nano.specs>) | ||
| endif() | ||
|
|
There was a problem hiding this comment.
Suggested change
| if(NOT (TARGET STM32::Nano)) | |
| add_library(STM32::Nano INTERFACE IMPORTED) | |
| target_compile_options(STM32::Nano INTERFACE $<$<C_COMPILER_ID:GNU>:--specs=nano.specs>) | |
| target_link_options(STM32::Nano INTERFACE $<$<C_COMPILER_ID:GNU>:--specs=nano.specs>) | |
| endif() | |
| if(NOT (TARGET STM32::Nano)) | |
| add_library(STM32::Nano INTERFACE IMPORTED) | |
| target_compile_options(STM32::Nano INTERFACE $<$<C_COMPILER_ID:GNU>:--specs=nano.specs>) | |
| target_link_options(STM32::Nano INTERFACE $<$<C_COMPILER_ID:GNU>:--specs=nano.specs>) | |
| #This custom property is used to check that specs is not set yet on a target linking to this one | |
| set_property(TARGET STM32::Nano PROPERTY INTERFACE_CUSTOM_GCC_SPECS "NANO") | |
| set_property(TARGET STM32::Nano APPEND PROPERTY | |
| COMPATIBLE_INTERFACE_STRING CUSTOM_GCC_SPECS) | |
| endif() | |
|
You must change the way NoSys is handle as well. |
- Readme file is updated to provide more details on the NoSys and Nano libraries. - A check was added to avoid linking both STM32::NoSys and STM32::Nano libraries.
|
@Hish15 Thank you. I updated the branch according to your suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linking STM32::Nano library in cmake.