Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ssz.go hashDefinitionVxyz #3319

Open
3 tasks
pinebit opened this issue Oct 3, 2024 · 0 comments
Open
3 tasks

Refactor ssz.go hashDefinitionVxyz #3319

pinebit opened this issue Oct 3, 2024 · 0 comments
Labels
enhancement New feature or request protocol Protocol Team tickets refactor Code refactoring

Comments

@pinebit
Copy link
Contributor

pinebit commented Oct 3, 2024

🎯 Problem to be solved

To reduce code duplication and to simplify introducing new cluster definition versions, the hashing functions need to be entirely refactored using modern Golang practices.

🛠️ Proposed solution

  • Check the existing code duplication among hashDefinitionVxyz() functions.
  • Design and refactor a better pattern that would simplify future new fields of cluster Definition object.

🧪 Tests

The existing test coverage is already great, so rely on the existing unit tests. Also, add more in case of drastic implementation changes.

  • Tested by new automated unit/integration/smoke tests
@pinebit pinebit added enhancement New feature or request refactor Code refactoring protocol Protocol Team tickets labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request protocol Protocol Team tickets refactor Code refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pinebit