Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Bug] console.error in Hashtag.spec.js #2161

Closed
Tirokk opened this issue Oct 5, 2020 · 2 comments
Closed

🐛 [Bug] console.error in Hashtag.spec.js #2161

Tirokk opened this issue Oct 5, 2020 · 2 comments
Labels
bug Something isn't working Github Import good first issue Good for newcomers service: webapp

Comments

@Tirokk
Copy link
Member

Tirokk commented Oct 5, 2020

mattwr18 Authored by mattwr18
Nov 7, 2019
Closed Nov 12, 2019


🐛 Bugreport

We are getting this error in components/Hashtag/Hashtag.spec.js:

console.error node_modules/vue/dist/vue.runtime.common.dev.js:621
      [Vue warn]: Unknown custom element: <nuxt-link> - did you register the component correctly? For recursive components, make sure to provide the "name" option.
      
      found in
      
      ---> <HcHashtag>
             <Root>

Steps to reproduce the behavior

  1. Pull down the latest changes from master
  2. from /webapp run yarn test components/Hashtag/Hashtag.spec.js
  3. see error in console

Expected behavior

We should not have runtime errors... please register nuxt-link properly in the test ☝️

Here is an example of how we have registered the component in the past https://github.com/Human-Connection/Human-Connection/blob/master/webapp/components/CommentList/CommentList.spec.js#L15

@Tirokk
Copy link
Member Author

Tirokk commented Oct 7, 2020

Mozar10 Authored by Mozar10
Nov 11, 2019


I added the fix for this, how should I contribute? just fork and PR?

@Tirokk
Copy link
Member Author

Tirokk commented Oct 7, 2020

mattwr18 Authored by mattwr18
Nov 11, 2019


please put in a PR to the repo directly! a fork will never pass our Travis build since we use encrypted env variables. see https://docs.travis-ci.com/user/environment-variables/#defining-encrypted-variables-in-travisyml for an explanation

@Mogge Mogge closed this as completed Oct 8, 2020
@Mogge Mogge added bug Something isn't working service: webapp Github Import good first issue Good for newcomers testing labels Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Github Import good first issue Good for newcomers service: webapp
Projects
None yet
Development

No branches or pull requests

2 participants