Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Bug] Post ribbons are positioned wrongly #3157

Closed
Tirokk opened this issue Oct 5, 2020 · 7 comments · Fixed by #6123 or #6130
Closed

🐛 [Bug] Post ribbons are positioned wrongly #3157

Tirokk opened this issue Oct 5, 2020 · 7 comments · Fixed by #6123 or #6130
Assignees

Comments

@Tirokk
Copy link
Member

Tirokk commented Oct 5, 2020

sushidave Authored by sushidave
Feb 25, 2020


🐛 Bugreport

In version 0.4.0 the post ribbons are positioned wrongly and they appear on top of the header instead of underneath it. See screenshot.

Steps to reproduce the behavior

  1. Log into the network.
  2. Check the post feed page.
  3. Scroll down to see the ribbons floating over the header.

See the blue ribbons on this screenshot:

hc-bug-post-ribbons-positioned-wrongly

Expected behavior

  • Ribbons positioned correctly
  • Ribbons underneath the header

Version & Environment

Type: [Notebook]

  • OS: [macOS]
  • Browser: [Firefox]
  • Version [73.0.1]
  • Device: [MacBook]

Additional context

Reported here: https://human-connection.social/post/4248d556-3130-461a-ab60-e15173c7eedd/v040-greater-fixfrontend-avatar-image-covers-full-circle-3102-danke-1#commentId-a59519bf-ded2-4fa0-9ef0-df86b9719d28

@Tirokk
Copy link
Member Author

Tirokk commented Oct 7, 2020

rbeer Authored by rbeer
Feb 25, 2020


Noticed that too, yesterday. At least on mobile they jump to their correct position when the associated card element receives focus.

On small screens, the Ribbon also cuts into the content, when its text is longer.
Screenshot_20200225-205914

@Tirokk
Copy link
Member Author

Tirokk commented Oct 7, 2020

Tirokk Authored by Tirokk
Apr 1, 2020


This is really ugly exactly. And therefor has a certain urgents in my eyes.
Can we change this @alina-beck ?
I would really appreciate. 🖖🏼

@Tirokk
Copy link
Member Author

Tirokk commented Oct 7, 2020

Tirokk Authored by Tirokk
Apr 6, 2020


I talked to @mattwr18 and he explains me that this is an issue which is already fixed and should have bee closed already @alina-beck .
Is that true, because here is no PR referenced …

@Tirokk
Copy link
Member Author

Tirokk commented Oct 7, 2020

alina-beck Authored by alina-beck
Apr 6, 2020


The scrolling on top of the header is fixed, the position of the ribbons is not.

What would you think about removing the ribbon altogether? I don't really see that it adds any value – at the moment it just clutters the UI.

@Tirokk
Copy link
Member Author

Tirokk commented Oct 7, 2020

sushidave Authored by sushidave
Apr 6, 2020


@alina-beck Hi Alina. I'm not sure about the removal of ribbons. Currently they are used for:

@Elweyn
Copy link
Member

Elweyn commented Mar 14, 2023

Their was no change merged in master, not done yet.

@Elweyn Elweyn reopened this Mar 14, 2023
@maeckes1
Copy link
Contributor

@Elweyn this was my fault. somehow i merged the wrong PR and so this issue was closed.
i am on it right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment