Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate package in favor of composer-runtime-api #139

Closed
Ocramius opened this issue Apr 24, 2020 · 3 comments
Closed

Deprecate package in favor of composer-runtime-api #139

Ocramius opened this issue Apr 24, 2020 · 3 comments

Comments

@Ocramius
Copy link
Owner

See composer/composer#8803

We can likely drop most of the contents of this library if we pin to composer/composer:^2.

After that, the library can be marked as security-only, and PackageVersions\Versions no longer needs to be generated, but rather relies on composer's built-in mechanisms.

Supersedes #135

@Ocramius Ocramius added this to the 1.9.0 milestone Apr 24, 2020
@Ocramius Ocramius self-assigned this Apr 24, 2020
@Ocramius Ocramius modified the milestones: 1.9.0, 1.10.0 Jun 22, 2020
@Ocramius
Copy link
Owner Author

This can be done in 2.0.0, once we can get rid of PackageVersions::ROOT_PACKAGE_NAME completely

@Ocramius
Copy link
Owner Author

Potentially to be done in 2.1.0 or later.

@Ocramius
Copy link
Owner Author

Decided that package is not to be deprecated: composer-runtime-api:^2 seems to break regularly, so having this package to at least test it regularly is not a bad idea.

In addition to that, this package at least provides a @psalm -friendly API exposing purity markers and guarantees on return types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant