You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A few concerns I have as I want to adopt this. I've seen some links breaking in this scenario where we do not use the supported MkDocs where you do relative linking to the markdown file.
Assuming site_url: http://localhost:8000, this would render to:
<!-- this works as expected -->
<a href="http://localhost:8000/contribute/">Not MkDocs supported</a>
<!-- this breaks since the page is compiled to contribute/index.html -->
<a href="http://localhost:8000/contribute.md">MkDocs supported</a>
I'm fine technically going against the spec as this plugin basically addresses everything as an external link. I can't think of a case where this would be an issue as we're basically removing all internal linking, but I just wanted to raise this and get some discussion/feedback for anyone else who shares this concern.
Edit:
This plugin will also break offline mode for those currently using mkdocs-materials plugins.
I almost wonder if there would be a similar way you could detect configurable set of file endings (e.g. .md), that don't get processed. I'm happy to look into this, but would like to know if you know of a better approach.
First off, thanks @foosel for this plugin!
A few concerns I have as I want to adopt this. I've seen some links breaking in this scenario where we do not use the supported MkDocs where you do relative linking to the markdown file.
For example:
Assuming
site_url: http://localhost:8000
, this would render to:I'm fine technically going against the spec as this plugin basically addresses everything as an external link. I can't think of a case where this would be an issue as we're basically removing all internal linking, but I just wanted to raise this and get some discussion/feedback for anyone else who shares this concern.
Edit:
This plugin will also break offline mode for those currently using mkdocs-materials plugins.
I almost wonder if there would be a similar way you could detect configurable set of file endings (e.g.
.md
), that don't get processed. I'm happy to look into this, but would like to know if you know of a better approach.Few links I don't want to lose:
The text was updated successfully, but these errors were encountered: