Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate alternate hashing algorithms #23

Open
droyad opened this issue Sep 26, 2019 · 2 comments
Open

Investigate alternate hashing algorithms #23

droyad opened this issue Sep 26, 2019 · 2 comments

Comments

@droyad
Copy link
Contributor

droyad commented Sep 26, 2019

Also, it would be interesting to use the xxHash algorithm instead of SHA1 (SHA1 has an average speed of 0.28 GB/s, while xxHash has 5.4 GB/s).

https://cyan4973.github.io/xxHash/

Originally posted by @arabasso in #21 (comment)

For Octopus we would need to figure out how we get the two ends to agree on the algorithm to be used.

@GrzegorzBlok
Copy link

@droyad xxHash64 is a default algorithm instead of SHA1 in a library that I derived from Octodiff:
https://github.com/GrzegorzBlok/FastRsyncNet
It works perfectly fine - it gives you significant faster calculations and smaller signature size.

@droyad
Copy link
Contributor Author

droyad commented Nov 19, 2019

@GrzegorzBlok Cool. The blocker for Octopus is negotiating between the two endpoints since either end could be running an older version of Octodiff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants